From d52b23dec384e766499bd9cac8f55010a644a034 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Florian=20M=C3=BCllner?= Date: Mon, 11 Nov 2019 22:00:01 +0100 Subject: [PATCH] switcherPopup: Improve modifier-less keybinding navigation Commit c899453800f11 lifted the requirement of switcher keybindings to contain a modifier, however it is currently only possible to finish it by letting it time out. Improve that by also accepting space/enter key presses to confirm the selection immediately. https://gitlab.gnome.org/GNOME/gnome-shell/issues/1883 --- js/ui/switcherPopup.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/js/ui/switcherPopup.js b/js/ui/switcherPopup.js index fc982781f..e5efcfaec 100644 --- a/js/ui/switcherPopup.js +++ b/js/ui/switcherPopup.js @@ -186,6 +186,14 @@ var SwitcherPopup = GObject.registerClass({ if (keysym === Clutter.KEY_Escape || keysym === Clutter.KEY_Tab) this.fadeAndDestroy(); + // Allow to explicitly select the current item; this is particularly + // useful for no-modifier popups + if (keysym === Clutter.KEY_space || + keysym === Clutter.KEY_Return || + keysym === Clutter.KEY_KP_Enter || + keysym === Clutter.KEY_ISO_Enter) + this._finish(keyEvent.time); + return Clutter.EVENT_STOP; } -- 2.39.5